TextLoader method override detection

[tmat]

Implements TextLoader API change #63888

Implements pattern used by BCL to deprecate public abstract methods:

• Update old method to call the new method.
• Change abstract to virtual if needed
• New method:
  • Use reflection to ask if the old method was overridden.
  • If it was overridden, call it, otherwise call old method.

We can still stack overflow if the old method is overridden but calls the base implementation.

[tmat]

@333fred @jasonmalinowski @AlekseyTs

[AlekseyTs]

Done with review pass (commit 1)

[333fred]

Done review pass (commit 2)

[AlekseyTs]

Done with review pass (commit 1 vs. 2)

[AlekseyTs]

Done with review pass (commit 5)

[tmat]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 4 pipeline(s).

[AlekseyTs]

LGTM (commit 5)

[333fred]

Consider explicitly specifying that this is a warning.

[333fred]

Is there a particular reason not to use a record struct here?

[AlekseyTs]

Is there a particular reason not to use a record struct here?

Yes, it generates a lot of things that we don't want

[333fred]

I'm not sure it does here. We seem to be very intentionally using all those things.