Fix DecodeForwardIteratorRecord to accept strings w/o null terminator #64349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cston PTAL |
cston
reviewed
Sep 29, 2022
| public void DecodeForwardIteratorRecord(byte[] bytes, string expected) | ||
| { | ||
| Assert.Equal(expected, CustomDebugInfoReader.DecodeForwardIteratorRecord(bytes.ToImmutableArray())); | ||
| } |
cston
approved these changes
Sep 29, 2022
333fred
approved these changes
Sep 29, 2022
cston
reviewed
Oct 10, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDI is not used by Roslyn EE. It is still decoded by Pdb2Xml tool which is using this helper and this fix allows Pdb2Xml to decode the data successfully.