Code

Implement Required Members for VB#66084

Code

Merged

333fred merged 22 commits intodotnet:maindotnet/roslyn:mainfrom 333fred:vb-required333fred/roslyn:vb-requiredCopy head branch name to clipboardMay 10, 2023

+4,305-224

Commits

Commits on Dec 21, 2022

• Add and implement IPropertySymbol.IsRequired and IFieldSymbol.IsRequired.

  333fred

  committed
  6615a4e

  Copy full SHA for 6615a4e

• Add and implement NamedTypeSymbol.AllRequiredMembers.

  333fred

  committed
  2c254bc

  Copy full SHA for 2c254bc

• Implement MethodSymbol.HasSetsRequiredMembers

  333fred

  committed
  de998f8

  Copy full SHA for de998f8

• Implement checking required members in constructors, sketch out test methods.

  333fred

  committed
  9b6b8af

  Copy full SHA for 9b6b8af

• Implement remaining errors:

  Show description for 98167b1
  333fred

  committed
  98167b1

  Copy full SHA for 98167b1

• Fill out all tests

  333fred

  committed
  7890731

  Copy full SHA for 7890731

Commits on Jan 5, 2023

• PR feedback

  333fred

  committed
  7b744a5

  Copy full SHA for 7b744a5

Commits on Jan 20, 2023

• PR feedback#

  333fred

  committed
  9ae7f8d

  Copy full SHA for 9ae7f8d

Commits on Jan 27, 2023

• PR Feedback

  333fred

  committed
  30ea028

  Copy full SHA for 30ea028

• Compile errors, missed feedback item.

  333fred

  committed
  b00b758

  Copy full SHA for b00b758

• Fix compile errors, add a few more tests.

  333fred

  committed
  7ec94f5

  Copy full SHA for 7ec94f5

Commits on Feb 6, 2023

• Merge remote-tracking branch 'upstream/main' into vb-required

  Show description for 624934a
  333fred

  committed
  624934a

  Copy full SHA for 624934a

Commits on Mar 11, 2023

• Addressed a number of PR feedback comments. Lots of new tests, fixed a few revealed bugs, handle Nothing converted to a struct with required members.

  333fred

  committed
  73d1d26

  Copy full SHA for 73d1d26

Commits on Mar 22, 2023

• PR feedback

  Show description for 8c9cff4
  333fred

  committed
  8c9cff4

  Copy full SHA for 8c9cff4

Commits on Mar 23, 2023

• Pass correct containing type in local rewriting of tuples.

  333fred

  committed
  58072b4

  Copy full SHA for 58072b4

Commits on May 2, 2023

• Merge remote-tracking branch 'upstream/main' into vb-required

  Show description for 610d5f4
  333fred

  committed
  610d5f4

  Copy full SHA for 610d5f4

• Fix test baseline

  333fred

  committed
  e1e3866

  Copy full SHA for e1e3866

Commits on May 5, 2023

• Simplify EnsureRequiredMembersCalcuated.

  333fred

  committed
  7b2052e

  Copy full SHA for 7b2052e

• Add additional test verification.

  333fred

  committed
  ebb5f25

  Copy full SHA for ebb5f25

Commits on May 10, 2023

• Remove unnecessary imports

  333fred

  committed
  e9e4ba6

  Copy full SHA for e9e4ba6

• Tighten retargeting asserts and add a test

  333fred

  committed
  748793f

  Copy full SHA for 748793f

• Fix C# equivalent code.

  333fred

  committed
  5575087

  Copy full SHA for 5575087