[Do Not Review] Scanner Perf #6641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds peep functionality into the scanner, which is combination of CanGet and Peek. It does not alter the existing content of the out parameter (ch) when CanGet is false. NOTE: This is different mechinism to TryParse methods, this is deliberate so that existing value can be used in subsequent conditions.
Usage of Peep in ScannerXML
Remove redundant `Me.` calls.
Check to see `DateIsInvalid = False` before doing additional work to see if date is invalid.
Tidy up `ScanIntLiteral` method signature.
Tweaks to the temporaries use with `Peep`. Removed some commented out code.
…Peep_2) * commit '9e38e83ea8d04cf4dfdcab70aa47aa4f0e2be6ef': Reduction in the number of temporary char variables from the use of `Peep` Minor Updates [Compiler VB Scanner] Tidy up `ScanIntLiteral` method signature. [Compiler VB Scanner] Check to see `DateIsInvalid = False` before doing additional work to see if date is invalid. [Compiler VB Scanner] Remove redundant `Me.` calls.
Utilise `Peep` in more places.
…the cast (if any) high up.
Contributor
Author
|
@dotnet-bot retest prtest/win/dbg/unit64 please. |
Member
|
Tag @dotnet/roslyn-compiler, can someone please take a look? |
Member
|
@davkean Why would we look at a "DO NOT REVIEW" PR? |
Contributor
|
@davkean The title of this pull request is "DO NOT REVIEW" |
Member
|
Ah, didn't see that, usually look at the labels. Adding them. |
davkean
added
PR For Personal Review Only
Contributor
Author
|
@davkean I'm an external contributor hence why I can't tag issues, so I prefix the title. |
davkean
added
the
Community
Member
|
Closing this as it has become stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just need some performance data on a "standard machine".