Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dead code #66815

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Delete dead code #66815

merged 1 commit into from
Feb 10, 2023

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #36138

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner February 10, 2023 18:53
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to delete, although I kinda wonder if we want this... :-/

@CyrusNajmabadi
Copy link
Member Author

Haven't needed it in 4 years. So either it goes, or someone makes a PR for it to come back. Regardless, it's in the history. So if it's needed just reference that :)

@CyrusNajmabadi CyrusNajmabadi merged commit 509b132 into dotnet:main Feb 10, 2023
@ghost ghost added this to the Next milestone Feb 10, 2023
{
var logFilePath = $"{Path.GetTempPath()}\\{Path.GetFileNameWithoutExtension(this.VisualStudioProject.FilePath)}_*.designtime.log";

var logFileDescription = string.Format(ServicesVSResources.To_see_what_caused_the_issue_please_try_below_1_Close_Visual_Studio_long_paragraph_follows, logFilePath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ Do any of these strings exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like yes. i'll remove them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up dead code in AbstractLegacyProject_IIntellisenseBuildTarget.cs
4 participants