Remove expensive call to ApplyPolicy #66845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the call to `ApplyPolicy` from our .NET Framework analyzer loading story. This call applies host policy to the given display name. That was likely added back in the days where we used `LoadFile` in the generator and hence needed to manually handle policy. These days though all our calls are via `LoadFrom` which has policy implicitly applied. Further this code path is only used as a final fall back now. By the time we get here it's assumed the host does not control the reference that is being loaded, it's owned by the analyzer. That means policy shouldn't even really apply. Removing this because it's unneeded and leads to perf issues in VS https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1742924
|
@dotnet/roslyn-compiler, @davkean |
333fred
approved these changes
Feb 13, 2023
RikkiGibson
approved these changes
Feb 14, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the call to
ApplyPolicyfrom our .NET Framework analyzer loading story. This call applies host policy to the given display name. That was likely added back in the days where we usedLoadFilein the generator and hence needed to manually handle policy. These days though all our calls are viaLoadFromwhich has policy implicitly applied.Further this code path is only used as a final fall back now. By the time we get here it's assumed the host does not control the reference that is being loaded, it's owned by the analyzer. That means policy shouldn't even really apply.
Removing this because it's unneeded and leads to perf issues in VS
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1742924