Clean with authority #66925
Merged
Clean with authority #66925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses `Remove-Item` to fully clean our build outputs once the build of the bootstrap compiler completes. This ensures there are no artifacts remaining that could interfere with our build using the bootstrap compiler
|
@dotnet/roslyn-infrastructure , @dibarbet PTAL |
333fred
approved these changes
Feb 17, 2023
RikkiGibson
reviewed
Feb 18, 2023
| @@ -333,6 +333,12 @@ function Make-BootstrapBuild([switch]$force32 = $false) { | |||
| Write-Host "Cleaning Bootstrap compiler artifacts" | |||
| Run-MSBuild $projectPath "/t:Clean" -logFileName "BootstrapClean" | |||
|
|
|||
| # Work around NuGet bug that doesn't correctly re-generate our project.assets.json files. | |||
There was a problem hiding this comment.
I am assuming that just finding and deleting those project.assets.json files isn't going to give the result we want?
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
Remove-Itemto fully clean our build outputs once the build of the bootstrap compiler completes. This ensures there are no artifacts remaining that could interfere with our build using the bootstrap compilerWork around for NuGet/Home#12437