Minor source build fixes #67028
Merged
Minor source build fixes #67028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of minor fixes to source build: 1. Force the build engine to be `dotnet` when doing a local source build. Using msbuild is not supported by arcade for source build and will lead to hard to track down errors. Force to `dotnet` to make it just work locally. 2. Exclude our .NET Framework ARM64 binaries from source build. No reason for them to be there.
|
@333fred, @dotnet/roslyn-compiler PTAL |
jjonescz
approved these changes
Feb 24, 2023
333fred
approved these changes
Feb 24, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of minor fixes to source build:
dotnetwhen doing a local source build. Using msbuild is not supported by arcade for source build and will lead to hard to track down errors. Force todotnetto make it just work locally.related to #66930