Skip to content

Add a couple of tests and remove unused EE source file #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cston merged 2 commits into from
Nov 16, 2015
Merged

Add a couple of tests and remove unused EE source file #6796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7ec815
Add tests
cston Nov 11, 2015
b49ae47
Remove unused ExpansionRow.cs
cston Nov 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Test/Symbol/Symbols/GenericConstraintTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,7 @@ static void M()
}

[WorkItem(528571, "DevDiv")]
[Fact(Skip = "528571")]
[Fact]
public void ConstraintsWithinStruct()
{
var source =
Expand Down
140 changes: 0 additions & 140 deletions src/ExpressionEvaluator/Core/Source/ResultProvider/ExpansionRow.cs
View file
Open in desktop

This file was deleted.

12 changes: 12 additions & 0 deletions src/Scripting/CSharpTest/InteractiveSessionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,18 @@ public void Fields_Visibility()
Assert.Equal(16, script.ContinueWith<int>("pi").EvaluateAsync().Result);
}

[WorkItem(100639)]
[Fact]
public void ExternDestructor()
{
var script = CSharpScript.Create(
@"class C
{
extern ~C();
}");
Assert.Null(script.EvaluateAsync().Result);
Copy link
Member

@amcasey amcasey Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this test? Did it used to throw?

Copy link
Contributor Author

@cston cston Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test would have resulted in an exception back when the bug was logged, but there have been significant changes to emit since then so that code path is no longer hit. But it seemed like an interesting test case.

}

#endregion

#region Chaining
Expand Down