Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant hex digit validator from lexer #68016

Merged
merged 1 commit into from
May 10, 2023
Merged

Remove redundant hex digit validator from lexer #68016

merged 1 commit into from
May 10, 2023

Conversation

jhinder
Copy link
Contributor

@jhinder jhinder commented Apr 28, 2023

Replace a custom hex digit validator, which was used in one location in the C# lexer, with SyntaxFacts.IsHexDigit.

@jhinder jhinder requested a review from a team as a code owner April 28, 2023 10:55
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 28, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 28, 2023
jcouv
jcouv approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this May 3, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label May 3, 2023
@jcouv jcouv added this to the 17.7 milestone May 3, 2023
@jcouv
Copy link
Member

jcouv commented May 9, 2023

@dotnet/roslyn-compiler for second review. Small cleanup PR. Thanks

@jcouv
Copy link
Member

jcouv commented May 9, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jcouv jcouv enabled auto-merge (squash) May 10, 2023 00:38
@jcouv jcouv merged commit 7eeb7ce into dotnet:main May 10, 2023
@ghost ghost modified the milestones: 17.7, Next May 10, 2023
@jcouv
Copy link
Member

jcouv commented May 10, 2023

Thanks @jhinder !

@allisonchou allisonchou mentioned this pull request May 12, 2023
Closed
@jhinder jhinder deleted the common-hexdigit-validation branch May 17, 2023 18:34
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@jhinder @jcouv @cston @Cosifne