Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if DocCookie is int instead of uint #68105

Merged
merged 2 commits into from
May 10, 2023
Merged

Check if DocCookie is int instead of uint #68105

merged 2 commits into from
May 10, 2023

Conversation

RadwanFaci
Copy link
Contributor

Although doc cookies are technically a uint, the window frame property apparently casts it as an int before returning it. This means that boxedDocCookie is uint docCookie always fails and we'll never run the code inside of that if block.

@RadwanFaci RadwanFaci requested a review from a team as a code owner May 4, 2023 22:21
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 4, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label May 4, 2023
@sharwell sharwell enabled auto-merge May 4, 2023 22:34
@RadwanFaci RadwanFaci closed this May 10, 2023
auto-merge was automatically disabled May 10, 2023 15:20

Pull request was closed

@RadwanFaci RadwanFaci reopened this May 10, 2023
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) May 10, 2023 18:48
@CyrusNajmabadi CyrusNajmabadi merged commit 5cedcb8 into dotnet:main May 10, 2023
@ghost ghost added this to the Next milestone May 10, 2023
@build-analysis build-analysis bot mentioned this pull request May 10, 2023
Open
5 tasks
@allisonchou allisonchou mentioned this pull request May 12, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@RadwanFaci @sharwell @CyrusNajmabadi @Cosifne