Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ServiceHub x64 vsix for integration test #68113

Merged
merged 3 commits into from
May 9, 2023

Conversation

genlu
Copy link
Member

@genlu genlu commented May 5, 2023

Fixing integration-corehost CI. Broken by the change that added a new vsix

@genlu genlu requested a review from a team as a code owner May 5, 2023 17:40
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels May 5, 2023
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ provided roslyn-integration-corehost passes

@genlu genlu requested a review from a team as a code owner May 5, 2023 19:50
@genlu
Copy link
Member Author

genlu commented May 5, 2023

OK, I could locally repro the same error as in integration CI (with int.Preview build)

PS C:\Program Files\Microsoft Visual Studio\2022\IntPreview> C:\Users\gel\Downloads\RoslynTools.VSIXExpInstaller.1.1.0-beta3.23252.1\tools\VSIXExpInstaller.exe /rootSuffix:RoslynDev /vsInstallDir:"C:\Program Files\Microsoft Visual Studio\2022\IntPreview" "C:\Users\gel\roslyn\artifacts\VSSetup\Debug\Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix"
"C:\Users\gel\Downloads\RoslynTools.VSIXExpInstaller.1.1.0-beta3.23252.1\tools\VSIXExpInstaller.exe" /rootSuffix:RoslynDev "/vsInstallDir:C:\Program Files\Microsoft Visual Studio\2022\IntPreview" C:\Users\gel\roslyn\artifacts\VSSetup\Debug\Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix
  Running as Admin.
  en-US
  Installing local extension: 'C:\Users\gel\roslyn\artifacts\VSSetup\Debug\Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix'

Unhandled Exception: System.InvalidOperationException: A value for 'Component' needs to be specified in the catalog.
   at Microsoft.VisualStudio.ExtensionManager.PackageInstaller.LoadComponent(IDependencyGraph dGraph, Boolean& isProductComponent)
   at Microsoft.VisualStudio.ExtensionManager.InstallModule.PerformSetupEngineInstall(InstallableExtensionImpl extensionToInstall, Boolean installPerMachine, Boolean isPackComponent, IDictionary`2 extensionsInstalledSoFar, List`1 extensionsUninstalledSoFar, IInstalledExtensionList modifiedInstalledExtensionsList, IProgress`1 progress, InstallFlags installFlags, AsyncOperation asyncOp, Version targetedVsVersion, IInstalledExtension& newExtension)
   at Microsoft.VisualStudio.ExtensionManager.InstallModule.InstallInternal(InstallableExtensionImpl extension, InstallFlags installFlags, IDictionary`2 extensionsInstalledSoFar, List`1 extensionsUninstalledSoFar, IInstalledExtensionList modifiedInstalledExtensionsList, AsyncOperation asyncOp, IProgress`1 progress, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.InstallModule.BeginInstall(IInstallableExtension installableExtension, InstallFlags installFlags, AsyncOperation asyncOp, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionEngineImpl.Install(IInstallableExtension extension, InstallFlags installFlags, Version targetedVsVersion)
   at Microsoft.VisualStudio.ExtensionManager.ExtensionManagerService.Install(IInstallableExtension extension, Boolean perMachine)
   at VsixExpInstaller.Program.<>c__DisplayClass16_0.<Main>g__Install|7(IInstallableExtension installableExtension, <>c__DisplayClass16_4& , <>c__DisplayClass16_5& ) in /_/src/VSIXExpInstaller/Program.cs:line 339
   at VsixExpInstaller.Program.<>c__DisplayClass16_0.<Main>g__RunProgram|1() in /_/src/VSIXExpInstaller/Program.cs:line 314
   at VsixExpInstaller.Program.Main(String[] args) in /_/src/VSIXExpInstaller/Program.cs:line 195

However, when using a VS build (from this validation insertion PR) that ships this servicehub.x64 vsix, it worked

PS C:\Program Files\Microsoft Visual Studio\2022\Preview> C:\Users\gel\Downloads\RoslynTools.VSIXExpInstaller.1.1.0-beta3.23252.1\tools\VSIXExpInstaller.exe /rootSuffix:RoslynDev /vsInstallDir:"C:\Program Files\Microsoft Visual Studio\2022\Preview" "C:\Users\gel\roslyn\artifacts\VSSetup\Debug\Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix"
"C:\Users\gel\Downloads\RoslynTools.VSIXExpInstaller.1.1.0-beta3.23252.1\tools\VSIXExpInstaller.exe" /rootSuffix:RoslynDev "/vsInstallDir:C:\Program Files\Microsoft Visual Studio\2022\Preview" C:\Users\gel\roslyn\artifacts\VSSetup\Debug\Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix
  Running as Admin.
  en-US
  Installing local extension (C:\Users\gel\roslyn\artifacts\VSSetup\Debug\Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix) over global extension (C:\PROGRAM FILES\MICROSOFT VISUAL STUDIO\2022\PREVIEW\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\VBCSHARP\LANGUAGESERVICES\CORE\)
    The extension was succesfully installed locally: 'C:\USERS\GEL\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\17.0_46CC08F2ROSLYNDEV\EXTENSIONS\E05WXOO2.CTS\'

So it seems the issue is Roslyn.VisualStudio.ServiceHub.Setup.x64.vsix is not installed as part of the VS already?

@genlu genlu force-pushed the InstallNewVsix branch from 4a7f9d4 to 9a7c13d Compare May 5, 2023 22:12
@genlu genlu marked this pull request as draft May 8, 2023 20:38
@genlu
Copy link
Member Author

genlu commented May 8, 2023

Convert to a draft PR until I figure out what's going on

@genlu genlu marked this pull request as ready for review May 9, 2023 21:51
@genlu
Copy link
Member Author

genlu commented May 9, 2023

integration test passed on core host.

@genlu genlu enabled auto-merge May 9, 2023 21:52
@genlu genlu merged commit f47ff93 into dotnet:main May 9, 2023
@ghost ghost added this to the Next milestone May 9, 2023
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants