Use a singleton sentinel for empty type-parameters for non-generic named-types and methods. #68131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
force-pushed
the
namedTypeParams
branch
from
f9194a3 to
1930390
Compare
CyrusNajmabadi
force-pushed
the
namedTypeParams
branch
from
1930390 to
987c5bf
Compare
CyrusNajmabadi
changed the title
|
@jaredpar ptal. |
CyrusNajmabadi
commented
May 8, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceNamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 8, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceNamedTypeSymbol.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 8, 2023
| @@ -23,7 +23,6 @@ namespace Microsoft.CodeAnalysis.CSharp.Symbols | |||
| /// </summary> | |||
| internal abstract class SourceOrdinaryMethodSymbolBase : SourceOrdinaryMethodOrUserDefinedOperatorSymbol | |||
| { | |||
| private readonly ImmutableArray<TypeParameterSymbol> _typeParameters; | |||
There was a problem hiding this comment.
methods were odd. _typeParameters was in SourceOrdinaryMethodSymbolBase (not SourceOrdinaryMethodSymbol), but was always empty for all other types. So this pushed this value down into SourceOrdinaryMethodSymbol, which could then use the new TypeParameterInfo object. All other methods just return 'Empty' from their TypeParameters helpers.
Note: this also ends up saving this extra pointer from all other source methods.
jcouv
reviewed
May 8, 2023
| /// <summary> | ||
| /// Wrapper around type-parameter/constraints/constraint-kind info. We wrap this information (instead of inlining | ||
| /// directly within type/method symbols) as most types/methods are not generic. As such, all those non-generic | ||
| /// types can point at the singleton sentivel <see cref="Empty"/> value, and avoid two pointers of overhead. |
jcouv
reviewed
May 8, 2023
src/Compilers/CSharp/Portable/Symbols/Source/TypeParameterInfo.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
May 8, 2023
src/Compilers/CSharp/Portable/Symbols/Source/TypeParameterInfo.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
May 9, 2023
jcouv
removed
the
untriaged
|
@dotnet/roslyn-compiler @cston ptal |
AlekseyTs
reviewed
May 11, 2023
src/Compilers/CSharp/Portable/Symbols/Source/TypeParameterInfo.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
May 11, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceOrdinaryMethodSymbol.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
May 11, 2023
src/Compilers/CSharp/Portable/Symbols/Source/SourceOrdinaryMethodSymbolBase.cs
Show resolved
Hide resolved
|
Done with review pass (commit 10) |
|
This is ready for review. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to address large heap usage of SourceNamedTypeSymbol and SourceOrdinaryMethodSymbol:
Takes us to:
Drops us 1.4%.