add Version.Details entries for source-build product build #68371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
added
the
Community
26 tasks
|
cc @NikolaMilosavljevic for awareness. |
333fred
approved these changes
May 30, 2023
|
@333fred thank you for the review! Could you please also merge it since I do not have write access. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3043
Declaring the listed dependency in
Version.Details.xmlwill allow source-build to replace the currently used versions with the n-1 version coming from previously source-built artifacts in the product / VMR build.Without this change, once repo PvP is enabled for
roslyn:Microsoft.CodeAnalysis.*will be marked as pre-builtsSystem.Compositionwould get loaded in during the build, and since we have the7.0.0version in the SBRP, it would fail due to it being a reference assembly