-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnC: Implement support for editing types with primary constructors #68477
Conversation
This might get simpler if we did two passes on the syntactic edits - first identifies what symbols need to be updated and the second can easily check for delete-insert pairs. Will explore that in a follow up. Refers to: src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs:6650 in 9283d26. [](commit_id = 9283d26, deletion_comment = False) |
src/Features/Core/Portable/EditAndContinue/EditAndContinueDiagnosticDescriptors.cs
Show resolved
Hide resolved
@davidwengier PTAL |
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Show resolved
Hide resolved
@dotnet/roslyn-compiler PTAL at compiler tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler tests LGTM (commit 8), with some comments for new test helpers.
Enables editing types with primary constructors and primary constructors themselves. Enables adding, deleting, renaming and changing types of parameters and switching from primary to non-primary constructor and vice versa.
Fixes various issues with editing record members and implements more unified approach that reduces special casing.
More work is needed to complete the experience and fix issues found during implementation.
Follow up issues: