Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread in the correct cancellation token into the code action operation #68859

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

mavasani
Copy link
Contributor

@mavasani mavasani commented Jul 3, 2023

Fixes AB#1826452

This seemed to be causing the configuration code actions to intermittenly be a no-op as the wrong cancellation token was being used. This feels like a candidate for a good analyzer, I'll file a analyzer suggestion on roslyn-analyzers.

Fixes [AB#1826452](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1826452)

This seemed to be causing the configuration code actions to intermittenly be a no-op as the wrong cancellation token was being used. This feels like a candidate for a good analyzer, I'll file a analyzer suggestion on roslyn-analyzers.
@mavasani mavasani requested a review from sharwell July 3, 2023 11:31
@mavasani mavasani requested a review from a team as a code owner July 3, 2023 11:31
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Jul 3, 2023
@mavasani mavasani enabled auto-merge July 3, 2023 16:09
@mavasani mavasani merged commit 5a1cc5f into dotnet:main Jul 3, 2023
@ghost ghost added this to the Next milestone Jul 3, 2023
@mavasani mavasani deleted the FixCancellationRace branch July 3, 2023 17:38
@allisonchou allisonchou modified the milestones: Next, 17.8 P1 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants