Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building with a dotnet not on PATH #69186

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Enable building with a dotnet not on PATH #69186

merged 3 commits into from
Jul 24, 2023

Commits on Jul 24, 2023

  1. Enable building with a dotnet not on PATH 

    In dotnet#68918 we removed inspecting DOTNET_HOST_PATH environment variable. This broke the scenario where a specific dotnet "hive" was installed to a location not on the PATH.

When the .NET SDK commands invoke a sub-process (for example MSBuild), it sets the DOTNET_HOST_PATH environment variable to tell the sub-process "this is where the dotnet.exe that invoked this command is located". See dotnet#21237 and dotnet/cli#7311 for more info.

This change reverts the behavior back to respect DOTNET_HOST_PATH, and if it isn't set it will just use "dotnet" and let the OS take care of finding the executable on the PATH.

Fix dotnet#69150
    @eerhardt
    eerhardt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    4d64983 View commit details
    Browse the repository at this point in the history

  2. Fix tests to workaround MSBuild searching the PATH itself.

    @eerhardt
    eerhardt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    214cb7b View commit details
    Browse the repository at this point in the history

  3. Respond to PR feedback. 

    Make the change smaller until @jaredpar gets back. Only make the minimal change required, which is to check DOTNET_HOST_PATH.
    @eerhardt
    eerhardt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    f392918 View commit details
    Browse the repository at this point in the history