Add support for reading runsettings passed by the client #69792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
JoeRobich
reviewed
Aug 31, 2023
src/Features/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Testing/RunTestsHandler.cs
Outdated
Show resolved
Hide resolved
|
|
||
| try | ||
| { | ||
| var contents = await File.ReadAllTextAsync(runSettingsPath, cancellationToken); |
There was a problem hiding this comment.
Should this line be wrapped in IOUtilities.PerformIOAsync?
There was a problem hiding this comment.
Hmm not sure. I think I would only catch and log the exception regardless of what kind it is? Not sure if I would do anything different if it wasn't a normal IO exception?
Cosifne
approved these changes
Sep 7, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final (known) change for dotnet/vscode-csharp#5719
Adds support for passing runsettings to vstest.
Client side PR: