Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analysis and emit difference time spans to EnC telemetry #69794

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Add analysis and emit difference time spans to EnC telemetry #69794

merged 2 commits into from
Sep 6, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Aug 31, 2023

No description provided.

@tmat tmat requested a review from a team as a code owner August 31, 2023 23:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 31, 2023
@tmat
Copy link
Member Author

tmat commented Aug 31, 2023

@phil-allen-msft

@build-analysis build-analysis bot mentioned this pull request Sep 1, 2023
Open
3 tasks
@tmat
Copy link
Member Author

tmat commented Sep 1, 2023

@davidwengier ptal

davidwengier
davidwengier approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve so you're not blocked on me, because its an otherwise straight forward PR and I trust you to make the updates, but to be very clear: As written this will report incorrect telemetry.

@tmat tmat merged commit 07df304 into dotnet:main Sep 6, 2023
24 checks passed
@tmat tmat deleted the EncTimingTelemetry branch September 6, 2023 17:40
@ghost ghost added this to the Next milestone Sep 6, 2023
@allisonchou allisonchou mentioned this pull request Sep 11, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @davidwengier @Cosifne