EnC: Generate correct state mapping for methods containing await foreach #69806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
tmat
force-pushed
the
EncAsyncIteratorFix
branch
from
7e06ae0 to
19de570
Compare
tmat
force-pushed
the
EncAsyncIteratorFix
branch
from
19de570 to
d8718a5
Compare
|
@cston @AlekseyTs @davidwengier @dotnet/roslyn-compiler PTAL |
cston
reviewed
Sep 19, 2023
src/Compilers/Core/Portable/Emit/EditAndContinueMethodDebugInformation.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Sep 19, 2023
src/Compilers/CSharp/Portable/BoundTree/BoundAwaitExpressionDebugInfo.cs
Show resolved
Hide resolved
cston
reviewed
Sep 19, 2023
src/Compilers/CSharp/Portable/BoundTree/BoundAwaitExpressionDebugInfo.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Sep 19, 2023
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_ForEachStatement.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Sep 25, 2023
jjonescz
approved these changes
Sep 26, 2023
|
@tmat consider retargeting to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
await foreachemits two async calls:MoveNextAsyncandDisposeAsync. Both are associated with the same syntax node (offset), which caused a collision in a syntax offset to state number map.The PR adds general support for language features that emit multiple awaits for a single syntax node. Currently that's only
await foreachin C#, but in future it may be other new language features.Each await associated with the same syntax node needs to be assigned a unique relative state ordinal. This number is then included in the key of the mapping.
Fixes #69805