Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test after merge #69836

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix test after merge #69836

merged 1 commit into from
Sep 6, 2023

Conversation

333fred
Copy link
Member

@333fred 333fred commented Sep 6, 2023

#69170 interacted badly with #69627. This fixes the test failure.

@333fred
Fix test after merge
4bfbd4c 
dotnet#69170 interacted badly with dotnet#69627. This fixes the test failure.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 6, 2023
@333fred 333fred marked this pull request as ready for review September 6, 2023 20:41
@333fred 333fred requested a review from a team as a code owner September 6, 2023 20:41
@333fred 333fred enabled auto-merge (squash) September 6, 2023 20:41
jcouv
jcouv approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv
Copy link
Member

jcouv commented Sep 6, 2023

Thanks!

@333fred
Copy link
Member Author

333fred commented Sep 6, 2023

Going to force merge after we see a green windows test run to unblock main PRs

@333fred 333fred merged commit 018243c into dotnet:main Sep 6, 2023
10 of 24 checks passed
@ghost ghost added this to the Next milestone Sep 6, 2023
@allisonchou allisonchou mentioned this pull request Sep 11, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers Area-IDE Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@333fred @jcouv @cston @Cosifne