Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix declaration snippets after partial keyword #69874

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix declaration snippets after partial keyword #69874

merged 1 commit into from
Sep 21, 2023

Conversation

DoctorKrolic
Copy link
Contributor

Fixes: #69600

The idea of a fix is to separate accessibility modifiers generation and main declaration generation into separate text changes. This way we can control what goes where.

Demo:
devenv_patxlcG8xX

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner September 10, 2023 18:29
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 10, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Sep 10, 2023
@DoctorKrolic DoctorKrolic mentioned this pull request Sep 11, 2023
Merged
@DoctorKrolic
Copy link
Contributor Author

@akhera99 PTAL

akhera99
akhera99 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@akhera99 akhera99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution!!

@akhera99 akhera99 merged commit 964e801 into dotnet:main Sep 21, 2023
@ghost ghost added this to the Next milestone Sep 21, 2023
@DoctorKrolic DoctorKrolic deleted the snippet-in-partial-declaration branch September 21, 2023 18:13
@DoctorKrolic DoctorKrolic mentioned this pull request Sep 22, 2023
Merged
@allisonchou allisonchou mentioned this pull request Sep 22, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhera99 akhera99 akhera99 approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.

Semantic snippets: possible duplication/wrong modifier order after partial keyword
3 participants
@DoctorKrolic @akhera99 @Cosifne