Use no-op global assembly cache helper when running under .net core #69936
Conversation
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
|
@tmat mind taking a look at this? Since it looks like you were the last one to actually modify these |
| @@ -27,7 +25,9 @@ private static GlobalAssemblyCache CreateInstance() | |||
| } | |||
| else | |||
| { | |||
| return new ClrGlobalAssemblyCache(); | |||
| return System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription.Contains(".NET Framework") | |||
There was a problem hiding this comment.
if there is a preferred way to do this let me know.
There was a problem hiding this comment.
Believe this is the preferred way. Pattern occurs several places in our code base.
|
@dotnet/roslyn-compiler could use a couple reviews on the shared file changes |
src/Scripting/Core/Hosting/Resolvers/DotNetCoreGlobalAssemblyCache.cs
Outdated
Show resolved
Hide resolved
src/Scripting/Core/Hosting/Resolvers/DotNetCoreGlobalAssemblyCache.cs
Outdated
Show resolved
Hide resolved
| @@ -27,7 +25,9 @@ private static GlobalAssemblyCache CreateInstance() | |||
| } | |||
| else | |||
| { | |||
| return new ClrGlobalAssemblyCache(); | |||
| return System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription.Contains(".NET Framework") | |||
There was a problem hiding this comment.
Believe this is the preferred way. Pattern occurs several places in our code base.
| /// However it isn't extremely straightforward to implement and we don't need it at this time so leaving it as a no-op. | ||
| /// More info on how this might be possible under a .net core runtime can be found https://github.com/dotnet/core/issues/3048#issuecomment-725781811 | ||
| /// </summary> | ||
| internal sealed class DotNetCoreGlobalAssemblyCache : GlobalAssemblyCache |
There was a problem hiding this comment.
Should we just make this type a singleton vs. creating a new one every time?
There was a problem hiding this comment.
Going to leave this as-is - this is already created as a singleton instance, as instantiated by the GlobalAssemblyCache.CreateInstance in the parent.
ghost
added this to the 
Should fix dotnet/vscode-csharp#6235
The
ClrGlobalAssemblyCache.csis used to find the implementation location of .net framework based assemblies that might be in the global assembly cache in order to decompile them.ClrGlobalAssemblyCache.csis not valid to use as-is when running in a .net core runtime - it is not valid to [DllImport("clr")] - in fact this generally throws a dll not found exception (it gets caught and reported as a NFW). I'm guessing in the above issue it managed to get a bit farther before throwing.The solution here is to avoid calling
ClrGlobalAssemblyCachewhen in .net core. I replaced it with a no-op implementation. While at some point it may be valuable to support decompiling .net framework assemblies in vscode, its not a high priority scenario and its not entirely clear on how that would be implemnted.