Add support for collection expressions in attributes #69968
Conversation
dotnet-issue-labeler
bot
added
the
untriaged
| var attr = (XAttribute)System.Attribute.GetCustomAttribute(typeof(C), typeof(XAttribute)); | ||
| Console.Write(attr._values.Length); | ||
|
|
||
| [X([])] |
There was a problem hiding this comment.
test with a string in the literal, and 'null' in the literal? #Resolved
|
|
||
| CreateCompilation(source).VerifyEmitDiagnostics( | ||
| // (1,14): error CS9176: There is no target type for the collection expression. | ||
| // [X([1, 2, .. [3]])] |
There was a problem hiding this comment.
definitely an odd error :) #Resolved
There was a problem hiding this comment.
I agree. It's an existing problem though and I'm not planning to address in this PR.
| public class XAttribute : System.Attribute | ||
| { | ||
| public int[] _values; | ||
| public XAttribute(int[] values) { _values = values; } |
There was a problem hiding this comment.
test with param int[]? #Resolved
jcouv
removed
the
untriaged
| // [X([1])] | ||
| Diagnostic(ErrorCode.ERR_BadAttributeParamType, "X").WithArguments("a", "A").WithLocation(12, 2) | ||
| ); | ||
| } |
| // [X([[1], [2]])] | ||
| Diagnostic(ErrorCode.ERR_BadAttributeParamType, "X").WithArguments("values", "int[][]").WithLocation(1, 2) | ||
| ); | ||
| } |
|
@jcouv make sure to retarget this to |
| } | ||
| """; | ||
|
|
||
| CreateCompilation(source, targetFramework: TargetFramework.Net70).VerifyEmitDiagnostics( |
| string source = """ | ||
| var attr = (XAttribute)System.Attribute.GetCustomAttribute(typeof(C), typeof(XAttribute)); | ||
| var inner = (int[])attr._values[0]; | ||
| System.Console.Write($"OuterLength={attr._values.Length} InnerValue={inner[0]} InnerLength={inner.Length}"); |
There was a problem hiding this comment.
Consider using attr._values.Report(); in this test and below. #Resolved
|
I haven't checked, but are there tests for using a collection-expr as an argument to an attribute 'named arg' and an attribute 'named field/prop'? #Resolved |
Thanks, that's a great suggestion. Not sure how I missed that. Will add some tests #Resolved |
|
Woohoo! Thanks for getting this in! |
Fixes #69133