Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate exception stack trace reporting from analyzers #70031

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Consolidate exception stack trace reporting from analyzers #70031

merged 2 commits into from
Sep 26, 2023

Conversation

jjonescz
Copy link
Member

Fixes #48008.

  • Adding the stack trace into diagnostic text for source generators as was already being done for analyzers.
  • Removing descriptions for those diagnostics since they seem no longer useful.

@jjonescz jjonescz added the Feature - Source Generators Source Generators label Sep 20, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 20, 2023
@jjonescz jjonescz added this to the 17.8 milestone Sep 20, 2023
@jjonescz jjonescz marked this pull request as ready for review September 20, 2023 13:12
@jjonescz jjonescz requested a review from a team as a code owner September 20, 2023 13:12
@jjonescz jjonescz requested a review from sharwell September 22, 2023 10:27
@jjonescz
Copy link
Member Author

@dotnet/roslyn-compiler for reviews, thanks

@jaredpar jaredpar removed the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 25, 2023
@jaredpar
Copy link
Member

@chsienki PTAL

@jjonescz jjonescz enabled auto-merge (squash) September 26, 2023 09:11
@jjonescz jjonescz merged commit 6d20799 into dotnet:main Sep 26, 2023
@jjonescz jjonescz deleted the 48008-SG-StackTrace branch September 26, 2023 10:38
@ghost ghost modified the milestones: 17.8, Next Sep 26, 2023
@jjonescz jjonescz mentioned this pull request Sep 26, 2023
Merged
@allisonchou allisonchou mentioned this pull request Oct 10, 2023
Closed
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@sharwell sharwell sharwell approved these changes

@chsienki chsienki chsienki approved these changes

Assignees

@jaredpar jaredpar

@chsienki chsienki

Labels
Area-Compilers Feature - Source Generators Source Generators
Projects
None yet
Milestone
17.9 P1
Development

Successfully merging this pull request may close these issues.

WRN_GeneratorFailedDuringGeneration isn't helpful without a StackTrace
4 participants
@jjonescz @jaredpar @sharwell @chsienki