Port accessibility fix for the text view control in lightbulb preview #70112
Conversation
Addresses [AB#1832532](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1832532) This PR ports the LSP editor (accessibility fix)[https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/496210] to the original Roslyn preview pane implementation. We now show an interactive preview, which has a left border showin `+` ir `-` for changes, and keyboard navigation and text selection are now enabled for the preview text view
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
| { | ||
| internal sealed partial class DifferenceViewerPreview | ||
| { | ||
| private sealed class NavigationalCommandTarget(ITextView textView, IEditorOperations editorOperations) : IOleCommandTarget |
There was a problem hiding this comment.
All the code in this file is a port from https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/496210
There was a problem hiding this comment.
i really hate this. is there any plan to make a reusable component here? this seems to be taking us backwards wrt to being able to use the editor cleanly.
|
|
||
| namespace Microsoft.CodeAnalysis.Editor.Implementation.Preview | ||
| { | ||
| internal sealed partial class DifferenceViewerPreview : IDifferenceViewerPreview<IWpfDifferenceViewer> |
There was a problem hiding this comment.
This is an existing type that is now moved to the Wpf layer.
Almost all the new code in this file is a port from https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/496210, while also retaining the prior code in https://github.com/dotnet/roslyn/blob/main/src/EditorFeatures/Core/Preview/DifferenceViewerPreview.cs.
| @@ -140,7 +140,7 @@ | |||
| <Separator Name="HeaderSeparator" Margin="0" Visibility="Collapsed"/> | |||
| </StackPanel> | |||
| <DockPanel Name="PreviewDockPanel" DockPanel.Dock="Top" Visibility="Collapsed"> | |||
| <ScrollViewer Name="PreviewScrollViewer" IsTabStop="True" | |||
| <ScrollViewer Name="PreviewScrollViewer" IsTabStop="False" | |||
There was a problem hiding this comment.
This tab stop is now moved to the text view control host
|
@dotnet/roslyn-ide can I please get another review? |
|
Thanks! |
ghost
added this to the 
|
@olegtk is this just a point in time thing, until we have a reusable difference viewer with the behavior needed? or is the expectation that roslyn always needs to own and maintain all this code? |
|
@CyrusNajmabadi yes, this is a tactical fix to satisfy October 6 SLA for this accessibility bug. Yes, we will provide an interactive diff viewer control in 17.9 to replace this. |
|
on our side it's tracked by https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1893411, so far scheduled for 17.9 Preview1. |
Addresses AB#1832532
This PR ports the LSP editor accessibility fix to the Roslyn preview pane implementation. We now show an interactive preview, which has a left border showing
+and-for the changes, and keyboard navigation and text selection are now enabled for the preview text view.Before (non-interactive)
After (interactive)