Allow only ordinary member method calls to be intercepted #70120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
jjonescz
approved these changes
Sep 27, 2023
cston
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70061
Spec says:
Looks like this wasn't thoroughly tested/the behaviors we expected in tests weren't in line with spec.
The interesting cases to test here are when we have an invocation in syntax but it's not invoking a member method, e.g. delegate, local function, and function pointer cases. I wasn't able to think of any others which are like that.
I tried to write a general purpose assertion for bound nodes which are associated with call syntax, to ensure we've always accounted for the possibility of the user trying to intercept the call in syntax. But the assertion I came up with ended up hitting too many cases for me to want to pursue adding it in this PR.