Check for particular collection expr attribute by name, as it can be provided internally in packages #70179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provided internally in packages
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
jnm2
reviewed
Sep 28, 2023
| @@ -513,23 +512,20 @@ or ImplicitStackAllocArrayCreationExpressionSyntax | |||
| } | |||
|
|
|||
| memberAccess = memberAccessExpression; | |||
| var createMethod = semanticModel.GetSymbolInfo(memberAccessExpression, cancellationToken).Symbol as IMethodSymbol; | |||
| if (createMethod is not { IsStatic: true }) | |||
| if (semanticModel.GetSymbolInfo(memberAccessExpression, cancellationToken).Symbol is not IMethodSymbol { IsStatic: true } createMethod) | |||
There was a problem hiding this comment.
Suggested change
| if (semanticModel.GetSymbolInfo(memberAccessExpression, cancellationToken).Symbol is not IMethodSymbol { IsStatic: true } createMethod) | |
| if (semanticModel.GetSymbolInfo(memberAccessExpression, cancellationToken).Symbol is not IMethodSymbol { IsStatic: true } createMethod) |
akhera99
approved these changes
Sep 28, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70178
Core issue here is that this attribute could jsut be internal, and included with a nuget package (like System.Collections.Immutable) to mark their types as supporting collection exprs. We should not assume there is a single well known attribute class that everyone will use.