Avoid infinite cycle caused by an early binding of DefaultParameterValue attribute. #70242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e attribute. Fixes dotnet#70206. Also: - Add support for using `nameof` in early bound well-known attributes - Address a number of issues with support for Asc, AscW, Chr, ChrW VB functions in early bound well-known attributes
dotnet-issue-labeler
bot
added
the
untriaged
|
@dotnet/roslyn-compiler Please review |
1 similar comment
|
@dotnet/roslyn-compiler Please review |
RikkiGibson
approved these changes
Oct 6, 2023
| switch (node.Kind()) | ||
| BoundExpression result = bindExpressionInternal(node, diagnostics, invoked, indexed); | ||
|
|
||
| if (IsEarlyAttributeBinder && result.Kind == BoundKind.MethodGroup && (!IsInsideNameof || EnclosingNameofArgument != node)) |
There was a problem hiding this comment.
I was wondering in what scenario is EnclosingNameofArgument != node needed for correct behavior?
There was a problem hiding this comment.
I was wondering in what scenario is
EnclosingNameofArgument != nodeneeded for correct behavior?
I have taken a conservatives approach to check for scenarios that I think can result in a successful binding in a most precise way. It is quite possible that I am missing some scenario and this condition is too strict, but I cannot think of any at the moment.
|
@dotnet/roslyn-compiler For the second review |
2 similar comments
|
@dotnet/roslyn-compiler For the second review |
|
@dotnet/roslyn-compiler For the second review |
333fred
approved these changes
Oct 10, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70206.
Also:
nameofin early bound well-known attributes in VB