Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lsp didChange processing. #70407

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #70392

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 17, 2023 17:58
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 17, 2023
{
await DidOpen(testLspServer, locationTyped.Uri);

await DidChange(testLspServer, locationTyped.Uri, (4, 8, "// there"), (4, 11, "hi "));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test demonstrates the fix.

@CyrusNajmabadi CyrusNajmabadi merged commit 2e99c97 into dotnet:main Oct 17, 2023
22 of 24 checks passed
@ghost ghost added this to the Next milestone Oct 17, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the lspText branch October 17, 2023 20:51
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LSP] textDocument/didChange handler behavior doesn't follow lsp spec
3 participants