Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect inline rename UI to editor smart rename session #70420

Merged
merged 40 commits into from
Oct 24, 2023

Add CompleteAsyncOperation

a5a4627
Select commit
Loading
Failed to load commit list.
Merged

Connect inline rename UI to editor smart rename session #70420

Add CompleteAsyncOperation
a5a4627
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Oct 23, 2023 in 0s

.NET Result Analysis

Details

Test Failures (21 tests failed)

🔹 [All failing tests from roslyn-integration-CI]

    ⚠️ 9 failing tests not displayed for this pipeline due to space limitations

    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyLocalVariableRenameWithCommentsUpdated [Details] [100.00% failure rate]
    [:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyLocalVariableRenameWithCommentsUpdated (VS2022)
      Exception Message
      Expected:
[145..146)
[287..288)
[305..306)
[321..322)
[348..349)
[427..428)
Actual:
[305..306)
[321..322)
[348..349)
Differences:
--> [145..146)
--> [287..288)
    [305..306)
    [321..322)
    [348..349)
--> [427..428)

      Expected: True
      
Actual:   False

      Stack Trace

         at Roslyn.Test.Utilities.AssertEx.SetEqual[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 483
      
at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.<VerifyLocalVariableRenameWithCommentsUpdated>d__9.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpRename.cs:line 281
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyLocalVariableRenameWithStringsUpdated [Details] [100.00% failure rate]
    [:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyLocalVariableRenameWithStringsUpdated (VS2022)
      Exception Message
      Expected:
[76..77)
[92..93)
[117..118)
[122..123)
[180..181)
[211..212)
Actual:
[76..77)
[92..93)
Differences:
    [76..77)
    [92..93)
--> [117..118)
--> [122..123)
--> [180..181)
--> [211..212)

      Expected: True
      
Actual:   False

      Stack Trace

         at Roslyn.Test.Utilities.AssertEx.SetEqual[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 483
      
at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.<VerifyLocalVariableRenameWithStringsUpdated>d__10.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpRename.cs:line 343
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyOverloadsUpdated [Details] [100.00% failure rate]
    [:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyOverloadsUpdated (VS2022)
      Exception Message
      Expected:
[27..37)
[56..66)
[124..134)
[178..188)
Actual:
[27..37)
[124..134)
Differences:
    [27..37)
--> [56..66)
    [124..134)
--> [178..188)

      Expected: True
      
Actual:   False

      Stack Trace

         at Roslyn.Test.Utilities.AssertEx.SetEqual[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 483
      
at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.<VerifyOverloadsUpdated>d__11.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpRename.cs:line 393
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

    ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyTextSync [Details] [100.00% failure rate]
    [:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.VerifyTextSync (VS2022)
      Exception Message
      System.ArgumentOutOfRangeException : Could not find a matching AdornmentLayerDefinition export for the requested adornment layer name.
Parameter name: name
      Stack Trace
         at Microsoft.VisualStudio.Text.Editor.Implementation.WpfTextView.GetAdornmentLayer(String name)
   at Roslyn.VisualStudio.IntegrationTests.InProcess.InlineRenameInProcess.<VerifyStringInFlyout>d__4.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/InlineRenameInProcess.cs:line 60
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpRename.<VerifyTextSync>d__18.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpRename.cs:line 669
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    ❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicRename.VerifyLocalVariableRenameWithCommentsUpdated [Details] [100.00% failure rate]
    [:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

    Failing Configurations (2)
    Data Driven SubResults
      ❌ Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicRename.VerifyLocalVariableRenameWithCommentsUpdated (VS2022)
      Exception Message
      Expected:
[146..147)
[275..276)
[293..294)
[319..320)
[345..346)
Actual:
[319..320)
[293..294)
[345..346)
Differences:
++> [319..320)
--> [146..147)
--> [275..276)
    [293..294)
--> [319..320)
    [345..346)

      Expected: True
      
Actual:   False

      Stack Trace

         at Roslyn.Test.Utilities.AssertEx.SetEqual[T](IEnumerable`1 expected, IEnumerable`1 actual, IEqualityComparer`1 comparer, String message, String itemSeparator, Func`2 itemInspector) in /_/src/Compilers/Test/Core/Assert/AssertEx.cs:line 483
      
at Roslyn.VisualStudio.NewIntegrationTests.VisualBasic.BasicRename.<VerifyLocalVariableRenameWithCommentsUpdated>d__5.MoveNext() in /_/src/VisualStudio/IntegrationTest/New.IntegrationTests/VisualBasic/BasicRename.cs:line 120
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      
--- End of stack trace from previous location where exception was thrown ---
      
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

🔹 [All failing tests from roslyn-integration-corehost]

    ⚠️ 7 failing tests not displayed for this pipeline due to space limitations

Was this helpful? Yes No

View more details on Build Analysis