Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extract-method to respect returning by-ref #70931

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #8439

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 22, 2023 02:00
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2023
@@ -29,6 +29,8 @@

namespace Microsoft.CodeAnalysis.CSharp.ExtractMethod
{
using static SyntaxFactory;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review with whitespace off.

@CyrusNajmabadi CyrusNajmabadi merged commit 132e539 into dotnet:main Nov 27, 2023
24 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the extractMethodRef branch November 27, 2023 22:31
@ghost ghost added this to the Next milestone Nov 27, 2023
@RikkiGibson RikkiGibson modified the milestones: Next, 17.9 P2 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref returns/locals: Extract Method does not generate ref-returning methods
3 participants