Include buildhost deps.json #71597
Merged
Include buildhost deps.json #71597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
force-pushed
the
build_host_deps
branch
from
6bcbe45 to
c9b2943
Compare
arunchndr
approved these changes
Jan 12, 2024
|
Failed timeout tests passed on rerun. This looks good to go if you are fine with it @jasonmalinowski |
jasonmalinowski
added a commit
to jasonmalinowski/vscode-csharp
that referenced
this pull request
Jan 12, 2024
This avoids having to merge dotnet/roslyn#71597 and then do a server update, to reduce risk.
- Change the target name so it's more aligned with otehr target names returning specific files. - Switch to TargetFrameworkIdentifier so we aren't testing for specific TFMs if we can avoid it.
jasonmalinowski
approved these changes
Jan 13, 2024
|
Tested on my side. I also pushed a commit to add a unit test which which at least directly looks for the deps.json file and will fail if we break the MSBuild side of things. |
|
/azp run roslyn-integration-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#6801
The .deps.json file in the build host was missing, leading to incorrect assembly resolution. It happened to work as long as the buildhost runtime was .net7