[Razor Cohost] Pass TextDocuments to Razor for text sync LSP messages #71671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dibarbet
approved these changes
Jan 17, 2024
ghost
added this to the
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Jan 26, 2024
…9831) Part of #9519 Right now code generation, in co-hosting and non, comes from document snapshots in the Razor project system which directly call the Razor compiler. This change means that all Html and C# code generation in co-hosting is done based on the TextDocument, which means it will come from the source generator when that part is ready. This is the Razor side of, and needs a Roslyn bump to, dotnet/roslyn#71671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original API I wrote for text sync for cohosting was sadly not sufficient to allow Razor to call the source generator. This fixes that by providing
TextDocuments in the didOpen/didChange/didClose requests.