Reduce allocations in AbstractRecommendationServiceBasedCompletionProvider.GetSymbolsAsync #72157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider.GetSymbolsAsync This method was individually adding items to an ArrayBuilder without it's size configured. Potential issues with the current approach: 1) There could be multiple resizes during the Add calls to get the array to it's final size 2) Very likely the final capacity will exceed the array size, causing an allocation in generating the immutablearray. 3) I was seeing a large number of items in these arrays, causing the array that does get created not to get freed back into the pool. Instead, if we use the SelectAsArray method, we shouldn't have any extra allocations other than the resultant ImmutableArray.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| var preselect = args.InferredTypes.Contains(GetSymbolType(symbol), SymbolEqualityComparer.Default) && !args.This.IsInstrinsic(symbol); | ||
| return new SymbolAndSelectionInfo(symbol, preselect); | ||
| }, | ||
| (InferredTypes: inferredTypes, This: this)); |
There was a problem hiding this comment.
nit: we often do @this or self.
CyrusNajmabadi
approved these changes
Feb 19, 2024
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was individually adding items to an ArrayBuilder without it's size configured. Potential issues with the current approach:
Instead, if we use the SelectAsArray method, we shouldn't have any extra allocations other than the resultant ImmutableArray.
Before allocations of type SymbolAndSelectionInfo[]:
After allocations of type SymbolAndSelectionInfo[]:
