Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excessive CPU classify large string literals with tons of embedded classifications in them. #72216

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix excessive CPU classify large string literals with tons of embedded classifications in them. #72216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/EditorFeatures/Core/Classification/TotalClassificationTaggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,12 @@ void AddEmbeddedClassifications()
// Only need to ask for the spans that overlapped the string literals.
using var _1 = SegmentedListPool.GetPooledList<ITagSpan<IClassificationTag>>(out var embeddedClassifications);

var stringLiteralSpans = new NormalizedSnapshotSpanCollection(stringLiterals.Select(s => s.Span));
var stringLiteralSpansFull = new NormalizedSnapshotSpanCollection(stringLiterals.Select(s => s.Span));

// The spans of the string literal itself may be far off screen. Intersect the string literal spans
// with the view spans to get the actual spans we want to classify.
var stringLiteralSpans = NormalizedSnapshotSpanCollection.Intersection(stringLiteralSpansFull, spans);

embeddedTagger.AddTags(stringLiteralSpans, embeddedClassifications);

// Nothing complex to do if we got no embedded classifications back. Just add in all the string
Expand Down
Loading