Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics #72296

chabiss · 2024-02-27T22:11:37Z

Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics is a ILspServiceFactory responsible for creating a workspace service, IVisualDiagnosticsLanguageService (the support for C#/XAML/Razor/CSS Hot Reload for MAUI), and delegating the IServiceBroker once the connection is created with C# Dev Kit
ServiceBrokerFactory imports IOnServiceBrokerInitialized
VisualDiagnosticsServiceFactory export IOnServiceBrokerInitialized and delegates to OnInitializedService which ensure the creation of the IVisualDiagnosticsLanguageService, once the broker service is initialized.

…s.VisualDiagnostics boostrapper

…tManagerService to the service container

…eference to LS server so that EA.VisualDiagnostics is part of the default ALC

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj

src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IVisualDiagnosticsLanguageService.cs

src/Tools/ExternalAccess/VisualDiagnostics/Internal/BrokeredDebuggerServices.cs

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj

src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiagnosticsServiceFactory.cs

…tions

src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IVisualDiagnosticsLanguageService.cs

src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IBrokeredDebuggerServices.cs

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj

src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiagnosticsServiceFactory.cs

… vdiag-lsp

src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiagnosticsServiceFactory.cs

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj

src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiagnosticsServiceFactory.cs

…ays guaranteed

…nosticsServiceFactory.cs Co-authored-by: David Barbet <dibarbet@gmail.com>

… vdiag-lsp

…rder for IVisualDiagnosticsLanguageService to load

… vdiag-lsp

…urce

src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IVisualDiagnosticsLanguageService.cs

src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiagnosticsServiceFactory.cs

...anguageServer/Microsoft.CodeAnalysis.LanguageServer/BrokeredServices/ServiceBrokerFactory.cs

…le to components consuming it

… vdiag-lsp

chabiss added 14 commits February 13, 2024 13:45

Initial skeletal/scapholding for Microsoft.CodeAnalysis.ExternalAcces…

4ce8633

…s.VisualDiagnostics boostrapper

Initial checkin of EA.VisualDiagnostics

95080d0

Add EA.VisualDiagnostics to the solution

a72da98

update to Workspage service

60e0a1f

First hook attempt to the IHotReloadSessionNotificationService

d42ef44

Remove the workaround

f85c280

debugging HotReloadSessionNotificationService

e0800d2

Register HotReloadSessionNotificationService and ManagedHotReloadAgen…

4a9ef11

…tManagerService to the service container

fix versioning on newtonsoft and merge conflicts

53ba8fb

clean code, check for cancellation token, add EA.VisualDiagnostic a r…

cd9ac23

…eference to LS server so that EA.VisualDiagnostics is part of the default ALC

Merge remote-tracking branch 'upstream/main' into vdiag-lsp

7cf123b

Update documentation

f259f18

Merge remote-tracking branch 'upstream/main' into vdiag-lsp

02329f9

Fix merge conflicts

90ab437

chabiss requested review from a team as code owners February 27, 2024 22:11

dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 27, 2024

etvorun suggested changes Feb 27, 2024

View reviewed changes

jjonescz reviewed Feb 28, 2024

View reviewed changes

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj Show resolved Hide resolved

jjonescz mentioned this pull request Feb 29, 2024

Check PublishData.json feeds #72333

Merged

mgoertz-msft reviewed Mar 1, 2024

View reviewed changes

src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiagnosticsServiceFactory.cs Outdated Show resolved Hide resolved

chabiss added 4 commits March 1, 2024 14:53

Code Review changes and addtion to RequestDataBridgeConnectionAsync

8b1c866

Fix BrokeredDebuggerServices internal Apis

9408002

Merge remote-tracking branch 'upstream/main' into vdiag-lsp

6ed8b47

replace loc to SemaphoreSlim which is more thread safe for await func…

448fe28

…tions

sharwell reviewed Mar 8, 2024

View reviewed changes

src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IVisualDiagnosticsLanguageService.cs Outdated Show resolved Hide resolved

sharwell reviewed Mar 8, 2024

View reviewed changes

src/Tools/ExternalAccess/VisualDiagnostics/Contracts/IBrokeredDebuggerServices.cs Outdated Show resolved Hide resolved

sharwell reviewed Mar 8, 2024

View reviewed changes

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj Outdated Show resolved Hide resolved

sharwell reviewed Mar 8, 2024

View reviewed changes

...ernalAccess/VisualDiagnostics/Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics.csproj Outdated Show resolved Hide resolved

dibarbet reviewed Mar 25, 2024

View reviewed changes

chabiss added 2 commits March 25, 2024 12:52

Removal of VisualDiagnosticsServiceBroker

e47cfc4

Merge branch 'vdiag-lsp' of https://github.com/chabiss/vdiag-lsp into…

41244c8

… vdiag-lsp

dibarbet reviewed Mar 25, 2024

View reviewed changes

chabiss and others added 2 commits March 25, 2024 13:32

add Contract.ThrowIfFalse(workspace != null) as Host Workspace is alw…

5eacd80

…ays guaranteed

Update src/Tools/ExternalAccess/VisualDiagnostics/Internal/VisualDiag…

32ee445

…nosticsServiceFactory.cs Co-authored-by: David Barbet <dibarbet@gmail.com>

This was referenced Mar 25, 2024

FixAllOccurrencesIgnoresGeneratedCode is flaky #56625

Open

newintegrationtests.csharp.csharpaddmissingreference.verifyavailablecodeactions (vs2022) #64807

Open

roslyn.visualstudio.newintegrationtests.csharp.csharpargumentprovider.fullcycle is flaky #66597

Open

chabiss added 7 commits March 25, 2024 17:36

Remove extra refererence no longer needed

6f88ecf

Merge branch 'vdiag-lsp' of https://github.com/chabiss/vdiag-lsp into…

74b6099

… vdiag-lsp

Fixing a VS coding guideline slip up

1f6f8fc

Add Microsoft.VisualStudio.Debugger.Contracts.dll as a reference in o…

ce7b628

…rder for IVisualDiagnosticsLanguageService to load

Add Microsoft.VisualStudio.Debugger.Contracts.dll as a reference in o…

aaa4e63

…rder for IVisualDiagnosticsLanguageService to load

Merge branch 'vdiag-lsp' of https://github.com/chabiss/vdiag-lsp into…

e814f44

… vdiag-lsp

Remove Microsoft.VisualStudio.Debugger.Contract because it's close so…

10511e4

…urce

dibarbet approved these changes Mar 26, 2024

View reviewed changes

etvorun approved these changes Mar 26, 2024

View reviewed changes

remove internalvisibleto

0dbc2b9

AArnott approved these changes Mar 26, 2024

View reviewed changes

chabiss added 5 commits March 26, 2024 15:08

changing to TrySetResult to pass tests

db1e028

Update comment

2120cf9

make IVisualDiagnosticsLanguageService internal to foce internalvisib…

a9c9937

…le to components consuming it

make IVisualDiagnosticsLanguageService internal to foce internalvisib…

51df9ab

…le to components consuming it

Merge branch 'vdiag-lsp' of https://github.com/chabiss/vdiag-lsp into…

7f916fa

… vdiag-lsp

dibarbet merged commit 0f35ec3 into dotnet:main Mar 29, 2024
30 checks passed

dotnet-policy-service bot added this to the Next milestone Mar 29, 2024

dotnet-bot mentioned this pull request Apr 9, 2024

[Automated] PRs inserted in VS build feature.dotnetVS-34808.241 #72953

Closed

dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics #72296

Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics #72296

chabiss commented Feb 27, 2024 •

edited

Loading

Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics #72296

Microsoft.CodeAnalysis.ExternalAccess.VisualDiagnostics #72296

Conversation

chabiss commented Feb 27, 2024 • edited Loading

chabiss commented Feb 27, 2024 •

edited

Loading