Remove eventing from ExternalErrorDiagnosticUpdateSource #72774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 5, 2024
| @@ -38,39 +38,6 @@ Namespace Microsoft.VisualStudio.LanguageServices.UnitTests.Diagnostics | |||
| End Using | |||
| End Sub | |||
|
|
|||
| <Fact> | |||
| Public Async Function TestExternalDiagnostics_RaiseEvents() As Task | |||
There was a problem hiding this comment.
this test effectively tests eventing.
CyrusNajmabadi
commented
Apr 5, 2024
|
|
||
| <Theory, CombinatorialData> | ||
| <WorkItem("https://github.com/dotnet/roslyn/issues/47754")> | ||
| Public Async Function TestExternalDiagnostics_CompilationEndAnalyzer(hasCompilationEndTag As Boolean) As Task |
There was a problem hiding this comment.
there's no special compilation end stuff happening here at all.
|
@mavasani this is ready for review. |
mavasani
approved these changes
Apr 5, 2024
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing but tests ever looked at these events. Note: we're still keeping the whole type around for now as there is still one codepath in teh IDE (project suppressions) that uses the information aggregated here to do work. But we can certainly make these types much simpler and saner by reducing the scope/size of their surface area. I also heavily want to get away from eventing as any sort of mechanism in diagnostics at any level.