Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply "Simplify updating the primary workspace without passing in a version #72808

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Reapply "Simplify updating the primary workspace without passing in a version #72808

merged 1 commit into from
Apr 1, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Mar 29, 2024 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 29, 2024
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review March 31, 2024 16:39
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner March 31, 2024 16:39
@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Mar 31, 2024 •
edited
Loading

@genlu @RikkiGibson reapplying this to roslyn. If you recall, the regressions last time (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullrequest/538549) were here:

image

But the reulsts of this run (https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/540551) shows effectively no change there:

image

No regressions are seen either with this change.

So i have no idea what happened with those runs, or why reverting had any impact. Perhaps just speedometer flakeyness?

@CyrusNajmabadi
Copy link
Member Author

@arkalyanms as well.

@CyrusNajmabadi CyrusNajmabadi merged commit 6e2ac12 into dotnet:main Apr 1, 2024
27 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the primaryWorkspace branch April 1, 2024 17:44
@dotnet-bot dotnet-bot mentioned this pull request Apr 7, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Apr 16, 2024
Closed
@CyrusNajmabadi
Copy link
Member Author

@jasonmalinowski For review when you get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu approved these changes

@RikkiGibson RikkiGibson Awaiting requested review from RikkiGibson

@arkalyanms arkalyanms Awaiting requested review from arkalyanms

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyrusNajmabadi @genlu