Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print diagnostics in invariant culture (English error messages) in assert text #72816

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Print diagnostics in invariant culture (English error messages) in assert text #72816

merged 1 commit into from
Apr 2, 2024

Conversation

DoctorKrolic
Copy link
Contributor

Assert text is only used when test fails to show expected vs actual diagnostics. Printing them with English messages won't break any culture-specific tests, but bring 2 positive changes:

  • If test fails in CI, diagnostic messages will be in English even in non-English pipelines
  • Folks with non-English language on their PC (for instance me) can copy-paste diagnostics from "Actual" section to the test without need to find original error messages in English

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner March 30, 2024 10:46
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 30, 2024
@jaredpar
Copy link
Member

jaredpar commented Apr 1, 2024

This seems reasonable to me but wanted to get @AlekseyTs take as he designed our locale strategy for testing

AlekseyTs
AlekseyTs approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs AlekseyTs merged commit c0d5ee2 into dotnet:main Apr 2, 2024
24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 2, 2024
@AlekseyTs
Copy link
Contributor

@DoctorKrolic Thanks for the contribution

@DoctorKrolic DoctorKrolic deleted the invariant-assert-text branch April 2, 2024 13:22
@dotnet-bot dotnet-bot mentioned this pull request Apr 7, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Apr 16, 2024
Closed
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P1
Development

Successfully merging this pull request may close these issues.
4 participants
@DoctorKrolic @jaredpar @AlekseyTs @dibarbet