Stop loading ISourceGenerators within VS entirely. #72835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
CyrusNajmabadi
commented
Apr 2, 2024
| { | ||
| using var connection = CreateConnection<TService>(callbackTarget: null); | ||
| return await connection.TryInvokeAsync(compilationState, projectId, invocation, cancellationToken).ConfigureAwait(false); | ||
| } |
There was a problem hiding this comment.
helper overload for the case where we're asking about a particular project in the context of a particular SolutionCompilationState (first time we've needed to do that).
CyrusNajmabadi
commented
Apr 2, 2024
| /// Whether or not the specified <paramref name="projectId"/> has source generators or not. | ||
| /// </summary> | ||
| ValueTask<bool> HasGeneratorsAsync( | ||
| Checksum solutionChecksum, ProjectId projectId, CancellationToken cancellationToken); |
There was a problem hiding this comment.
Pretty self-explanatory.
CyrusNajmabadi
commented
Apr 2, 2024
| { | ||
| using var generators = TemporaryArray<ISourceGenerator>.Empty; | ||
| var generatorToAnalyzerReference = ImmutableDictionary.CreateBuilder<ISourceGenerator, AnalyzerReference>(); | ||
| private static readonly ConditionalWeakTable<ProjectState, SourceGeneratorMap> s_projectStateToSourceGeneratorsMap = new(); |
There was a problem hiding this comment.
this was a simpler way to organize the existing information. ProjectState already has the language and analyzerreferences. It's also what callers already pass in. And it's a green node which rarely changes. Note: if it does change, we'll 'recompute' the SGs, but end up finding the same set, since the AnalyzerRef objects themselves cache and return the same instances.
CyrusNajmabadi
commented
Apr 2, 2024
| /// process (if present) and having it make the determination, without the host necessarily loading generators | ||
| /// itself. | ||
| /// </summary> | ||
| private static readonly ConditionalWeakTable<ProjectState, AsyncLazy<bool>> s_hasSourceGeneratorsMap = new(); |
ToddGrun
reviewed
Apr 2, 2024
| /// process (if present) and having it make the determination, without the host necessarily loading generators | ||
| /// itself. | ||
| /// </summary> | ||
| private static readonly ConditionalWeakTable<ProjectState, AsyncLazy<bool>> s_hasSourceGeneratorsMap = new(); |
There was a problem hiding this comment.
tried, but it started getting very ugly/allocy
ToddGrun
reviewed
Apr 2, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState_SourceGenerators.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 2, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState_SourceGenerators.cs
Show resolved
Hide resolved
ToddGrun
reviewed
Apr 2, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState_SourceGenerators.cs
Outdated
Show resolved
Hide resolved
ToddGrun
approved these changes
Apr 2, 2024
This was referenced Apr 13, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.