Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest where keyword in generic local function declarations #72838

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Suggest where keyword in generic local function declarations #72838

merged 4 commits into from
Apr 2, 2024

Conversation

Rekkonnect
Copy link
Contributor

@Rekkonnect Rekkonnect commented Apr 2, 2024 •
edited
Loading

Closes #72821

@Rekkonnect Rekkonnect requested review from a team as code owners April 2, 2024 12:12
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 2, 2024
@DoctorKrolic
Copy link
Contributor

This also adds a public API:

Public APIs need to go through API review process first. You cannot just add public API to simplify your IDE fix as you go

sharwell
sharwell requested changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the Arity property and inline the computed value where it was used.

@Rekkonnect
Copy link
Contributor Author

@sharwell removed the public API, ptal

@Rekkonnect Rekkonnect requested a review from sharwell April 2, 2024 12:54
@sharwell sharwell enabled auto-merge April 2, 2024 14:12
@build-analysis build-analysis bot mentioned this pull request Apr 2, 2024
Open
3 tasks
@Rekkonnect
Copy link
Contributor Author

@sharwell can you please rerun the checks that crashed?

CyrusNajmabadi
CyrusNajmabadi approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with suggestions.

@Rekkonnect @CyrusNajmabadi
Suggestions
712d9f2 
Co-Authored-By: Cyrus Najmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
auto-merge was automatically disabled April 2, 2024 16:01

Head branch was pushed to by a user without write access

@sharwell sharwell enabled auto-merge April 2, 2024 16:21
@sharwell sharwell merged commit cf8b467 into dotnet:main Apr 2, 2024
27 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 2, 2024
@Rekkonnect Rekkonnect deleted the fix/72821 branch April 2, 2024 17:27
@dotnet-bot dotnet-bot mentioned this pull request Apr 13, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Apr 16, 2024
Closed
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.11 P1
Development

Successfully merging this pull request may close these issues.

where is not suggested when adding the first type constraint to a local function
5 participants
@Rekkonnect @DoctorKrolic @sharwell @CyrusNajmabadi @dibarbet