Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deviation from member lookup standard #72858

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Apr 3, 2024

No description provided.

@jcouv jcouv self-assigned this Apr 3, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 3, 2024
@jcouv jcouv marked this pull request as ready for review April 17, 2024 01:04
@jcouv jcouv requested a review from a team as a code owner April 17, 2024 01:04
@@ -35,3 +35,38 @@ class EnumConversionTest
```

Conversions are (correctly) *not* permitted from constant expressions which have a type of `bool`, other enumerations, or reference types.

# Member lookup
Copy link
Member

@jjonescz jjonescz Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be second-level heading (##)? Similarly would fix the existing one. #ByDesign

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was intentional to have "Implicit enum conversions from zero" under "Conversions".
But "Member lookup" doesn't belong under "Conversions", so I have it at top-level

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, I meant also ## Conversions should be second-level (and ### Implicit enum conversions from zero third-level), because there should be only a single top-level heading in a Markdown document which here is # Deviations from the C# standard. But nevermind, it's just a nit.


Roslyn instead implements a preference for methods over non-method symbols:

```
Copy link
Member

@jjonescz jjonescz Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider marking the code blocks as C# for better rendering #Resolved

@jcouv jcouv merged commit e2a1f8f into main Apr 18, 2024
5 checks passed
@jcouv jcouv deleted the dev/jcouv/deviation-lookup branch April 18, 2024 00:28
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 18, 2024
@dibarbet dibarbet modified the milestones: Next, 17.11 P1 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Documentation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants