-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document deviation from member lookup standard #72858
Conversation
@@ -35,3 +35,38 @@ class EnumConversionTest | |||
``` | |||
|
|||
Conversions are (correctly) *not* permitted from constant expressions which have a type of `bool`, other enumerations, or reference types. | |||
|
|||
# Member lookup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be second-level heading (##
)? Similarly would fix the existing one. #ByDesign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was intentional to have "Implicit enum conversions from zero" under "Conversions".
But "Member lookup" doesn't belong under "Conversions", so I have it at top-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry, I meant also ## Conversions
should be second-level (and ### Implicit enum conversions from zero
third-level), because there should be only a single top-level heading in a Markdown document which here is # Deviations from the C# standard
. But nevermind, it's just a nit.
|
||
Roslyn instead implements a preference for methods over non-method symbols: | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider marking the code blocks as C# for better rendering #Resolved
No description provided.