Add a unit test to cover the unified setting's registration file. #72946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Kindly tag @sharwell to review. |
sharwell
reviewed
Apr 9, 2024
src/VisualStudio/CSharp/Test/UnifiedSettings/CSharpUnifiedSettingsTests.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Apr 9, 2024
src/VisualStudio/CSharp/Test/UnifiedSettings/CSharpUnifiedSettingsTests.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Apr 9, 2024
src/VisualStudio/Core/Test/UnifiedSettings/UnifiedSettingsTests.vb
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Apr 9, 2024
|
|
||
| ' Mapping from the config name to its path in Unified Settings registration file | ||
| Private Shared ReadOnly s_unifiedSettingsStorage As New Dictionary(Of String, UnifiedSettingsStorage)() From { | ||
| {"dotnet_trigger_completion_on_typing_letters", New UnifiedSettingsStorage("textEditor.%LANGUAGE%.intellisense.triggerCompletionOnTypingLetters")}, |
There was a problem hiding this comment.
💭 Is this mapping not anywhere else?
There was a problem hiding this comment.
They might be moved to
in futureUnified Settings provides
Microsoft.VisualStudio.Utilities.UnifiedSettings.ISettingsManager, which would replace the usage of all old ISettingsManager2 IVsFeatureFlag and etc... but it's not required now.
sharwell
approved these changes
Apr 11, 2024
src/VisualStudio/Core/Test/Microsoft.VisualStudio.LanguageServices.UnitTests.vbproj
Outdated
Show resolved
Hide resolved
|
/azp run roslyn-integratoin-CI |
|
No pipelines are associated with this pull request. |
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test-only change.
Originally mentioned by Sam somewhere we need some tests to guard the registration files of Unified Settings.
This PR adds unit test to cover the C# Intellisense page.
It covers
ISettingManager. Make sure the value is correct and matchesroslyn/src/VisualStudio/Core/Def/Options/VisualStudioOptionStorage.cs
Line 116 in 7bf0187
This would ensure we don't make simple mistakes like typo in the registration file.
The general test code is put under
Microsoft.VisualStudio.LanguageServices.UnitTests, and the real test is put underMicrosoft.VisualStudio.LanguageServices.CSharp.UnitTests, so that later we can onboard the VB tests easily.