Restore case insensitivity with file paths and related doc ids in the workspace #72965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 10, 2024
src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Apr 10, 2024
| Assert.Equal(documentFilePath, document.FilePath); | ||
| } | ||
|
|
||
| // Try again, this time with a uri with different case sensitivity. This is supported, and is needed by Xaml. |
There was a problem hiding this comment.
to clarify - its needed by all files (including cs files) - C# devkit is adding them as upper case drive letters (but the URIs from the client are lowercase drive letters).
dibarbet
approved these changes
Apr 10, 2024
This was referenced Apr 11, 2024
This was referenced Apr 13, 2024
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #72959