Sync small-sized information across all projects in one batch call. #72975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 10, 2024
CyrusNajmabadi
commented
Apr 10, 2024
| } | ||
|
|
||
| await SynchronizeProjectAssetsAsync(allProjectStateChecksums, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
pass in all projects of interest here so we can sync individual bits of data for all of them at once.
CyrusNajmabadi
commented
Apr 10, 2024
| AddAll(checksums, projectChecksums.Documents.Checksums); | ||
| AddAll(checksums, projectChecksums.AdditionalDocuments.Checksums); | ||
| AddAll(checksums, projectChecksums.AnalyzerConfigDocuments.Checksums); | ||
| { |
There was a problem hiding this comment.
there's a lot of duplication that happens in the new code. the followup moves those into helpers that dedupe the pattern.
There was a problem hiding this comment.
the followup also makes us do this work in parallel
CyrusNajmabadi
commented
Apr 10, 2024
CyrusNajmabadi
commented
Apr 10, 2024
CyrusNajmabadi
commented
Apr 10, 2024
| @@ -264,16 +264,25 @@ static SourceGeneratorExecutionVersionMap FilterToProjectCone(SourceGeneratorExe | |||
| } | |||
|
|
|||
| using var _2 = ArrayBuilder<ProjectInfo>.GetInstance(out var projectInfos); | |||
| using var _3 = ArrayBuilder<ProjectStateChecksums>.GetInstance(out var projectStateChecksumsToAdd); | |||
|
|
|||
| // added project | |||
| foreach (var (projectId, newProjectChecksums) in newProjectIdToStateChecksums) | |||
There was a problem hiding this comment.
two loops now. the first to collect the projects to bulk sync. the second create the projectinfos with the newly sync'ed data to update the solution
|
@ToddGrun this is ready for review. |
|
@jasonmalinowski For review when you get back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a solution like roslyn, we end up having 900 "projects" (where you get multiple roslyn-projects corresponding to each flavor a normal vs project). Querying for data for these individually adds up. Now, we can do things like ask for the attributes of all those projects in a single batch call.
What we still do at a per-project level is query it for its documents.
Note: there will be a followup to this PR that takes all these calls and allows them to run in parallel (dropping sync time in about 1/3rd).