Specially handle more scenarios for type parameters with 'allows ref struct' constraint #73305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…struct' constraint
dotnet-issue-labeler
bot
added
the
untriaged
jjonescz
reviewed
May 3, 2024
| @@ -754,6 +773,11 @@ static bool isUtf8ByteRepresentation(BoundExpression value) | |||
| { | |||
| return value is BoundUtf8String or BoundBinaryOperator { OperatorKind: BinaryOperatorKind.Utf8Addition }; | |||
| } | |||
|
|
|||
| Conversion getOperandConversionForAllowByRefLikeNullCheck(bool isChecked, BoundExpression operand, TypeSymbol objectType, ref CompoundUseSiteInfo<AssemblySymbol> useSiteInfo) | |||
There was a problem hiding this comment.
Static?
Conversion is an instance member.
| EmitExpression(comparand, true); | ||
|
|
||
| object falseLabel = new object(); | ||
| var endLabel = new object(); |
There was a problem hiding this comment.
Nit: consider making both variables consistently either var or object. #Resolved
| .maxstack 1 | ||
| IL_0000: ldarg.0 | ||
| IL_0001: box ""T"" | ||
| IL_0006: brtrue.s IL_000a |
There was a problem hiding this comment.
Why don't we emit branchless code like box; ldnull; ceq instead? #Resolved
There was a problem hiding this comment.
Why don't we emit branchless code like box; ldnull; ceq instead?
Because that IL sequence is illegal for type parameters that allow ref struct. Boxing is not supported for them in general, but an exception is made for box, brtue/brfalse sequence.
jjonescz
approved these changes
May 3, 2024
|
@cston, @dotnet/roslyn-compiler For the second review |
cston
approved these changes
May 3, 2024
AlekseyTs
merged commit 449738c
into
dotnet:features/RefStructInterfaces
24 checks passed
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.