Do less work computing diff-merge results in the common case. #73430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iffMergingSession.cs
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
less work Simplify Fix test Add back Simplify Fix rename lint
CyrusNajmabadi
commented
May 10, 2024
| @@ -5769,7 +5769,7 @@ public class Goo | |||
| { | |||
| public void Bar() | |||
| { | |||
| var target = new List<object;gt>(); | |||
| var target = new List<object>(); | |||
There was a problem hiding this comment.
tests were wonky.
CyrusNajmabadi
commented
May 10, 2024
| appliedChanges = await AddDocumentMergeChangesAsync( | ||
| oldSolution.GetDocument(documentId), | ||
| newSolution.GetDocument(documentId), | ||
| [.. appliedChanges], |
There was a problem hiding this comment.
this was converting an IA into a list, that was never mutated. made the input/output entirely IA bases.
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #73424