Install SDK in devcontainer based on global.json #73526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
trying a different approach... |
jaredpar
previously approved these changes
May 17, 2024
|
I should have thought of this when I moved the SDK. Thanks for taking care of it. |
dibarbet
force-pushed
the
net9_devcontainer
branch
from
c38b59c to
13e7294
Compare
dibarbet
changed the title
|
@jaredpar for re-review, I took a bit of a different approach |
jaredpar
approved these changes
May 17, 2024
JoeRobich
approved these changes
May 17, 2024
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having to continually update the devcontainer base image we're using whenever our global.json updates (or doesn't update), we just use a base image and additionally install the SDK from our global.json into that same install location.