Remove 'flavors' from FAR results #73592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
May 20, 2024
src/VisualStudio/Core/Def/FindReferences/StreamingFindUsagesPresenter.cs
Show resolved
Hide resolved
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has several positive results for FAR scenarios.
First, the time taken to present results drops dramatically. In testing, this takes us down from ~25-30 seconds to present results, to <10s.
Second, the UI is much more 'stable' when results are being shown. As you can see from teh gif below, when we add a new 'flavor' to a project, the FAR window (platform-owned) thinks of it as a new top level group. It first will 'drain' the items from the prior gruop, and then add them all to the new group. This is both costly in terms of time, as well as confusing in terms of UX (since hte far numbers go down as you're watching them!).
Here's what it looks like before (note the numbers going up and down spastically):
And afterwards: